Stop referencing the VMware Harbor registry for ipfix-collector #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ipfix-collector YAML manifest should no longer reference the VMware Harbor registry. The image should be pulled from DockerHub. See antrea-io/antrea#6003 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 72.88% 72.88%
=======================================
Files 19 19
Lines 2854 2854
=======================================
Hits 2080 2080
Misses 602 602
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Although I don't think anyone is actively using the kafka and zookeeper images, should we also move them to Antrea DockerHub to avoid deadlinks? |
|
@heanlan this can be done in a future PR, the images should not be going away any time soon, but we won't be able to push new ones |
heanlan
approved these changes
Mar 7, 2024
|
Would you need a new tag at the moment? @antoninbas |
|
@heanlan No need for a tag, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ipfix-collector YAML manifest should no longer reference the VMware Harbor registry. The image should be pulled from DockerHub.
See antrea-io/antrea#6003