Add more features to test IPFIX collector web API #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying records, one can now specify the max number of flows that should be returned (starting with the most recent one), as well as the format of the response (json or text). We also add a size limit for the flowRecords slice, to avoid unbounded memory usage. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
yuntanghsu
reviewed
Jun 3, 2024
yuntanghsu
reviewed
Jun 3, 2024
cmd/collector/collector_test.go
Outdated
| require.NoError(t, err) | ||
|
|
||
| if expectedStatus != http.StatusOK { | ||
| return |
There was a problem hiding this comment.
I think this return will ignore the last 3 tests.
There was a problem hiding this comment.
yes, that's correct, good catch
I forgot to call t.Run to define the subtests
Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying records, one can now specify the max number of flows that should be returned (starting with the most recent one), as well as the format of the response (json or text).
We also add a size limit for the flowRecords slice, to avoid unbounded memory usage.