From 79bc73cb0418aadf762913340bf39c365c6a9746 Mon Sep 17 00:00:00 2001 From: Gary Blake <31245616+GaryJBlake@users.noreply.github.com> Date: Wed, 5 Jun 2024 10:57:25 +0100 Subject: [PATCH] fix: order of nsx syslog configuration (#647) - Fixed `Invoke-IlaDeployment` cmdlet to configure NSX Syslog servers in the correct order after connecting VI Workload Domains. Signed-off-by: Gary Blake --- CHANGELOG.md | 1 + PowerValidatedSolutions.psd1 | 2 +- PowerValidatedSolutions.psm1 | 20 ++++++++++---------- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3171f937..05cff2aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ - Added `Remove-AriaNetworksDataSource` cmdlet to remove a data source from VMware Aria Operations for Networks. - Added `New-AriaNetworksvCenterDataSource` cmdlet to add a vCenter Server in VMware Aria Operations for Networks. - Fixed `Invoke-IamDeployment` and `Invoke-UndoIamDeployment` cmdlets where it was not discovering the NSX service accounts correctly. +- Fixed `Invoke-IlaDeployment` cmdlet to configure NSX Syslog servers in the correct order after connecting VI Workload Domains. - Enhanced `config.PowerValidatedSolutions` configuration file to include VMware Cloud Foundation 5.2 support. - Enhanced `Install-vRSLCMCertificate` cmdlet to perform additional checks that a Microsoft Certificate Authority is configured in SDDC Manager. - Enhanced `Test-PrereqApplicationVirtualNetwork` cmdlet to allow validation of either X_REGION or REGION_A networks. diff --git a/PowerValidatedSolutions.psd1 b/PowerValidatedSolutions.psd1 index 20f911db..2470e4ce 100644 --- a/PowerValidatedSolutions.psd1 +++ b/PowerValidatedSolutions.psd1 @@ -11,7 +11,7 @@ RootModule = 'PowerValidatedSolutions.psm1' # Version number of this module. - ModuleVersion = '2.11.0.1008' + ModuleVersion = '2.11.0.1009' # Supported PSEditions # CompatiblePSEditions = @() diff --git a/PowerValidatedSolutions.psm1 b/PowerValidatedSolutions.psm1 index 12c355d7..45b6965e 100644 --- a/PowerValidatedSolutions.psm1 +++ b/PowerValidatedSolutions.psm1 @@ -12977,6 +12977,16 @@ Function Invoke-IlaDeployment { # messageHandler -statusMessage $StatusMsg -warningMessage $WarnMsg -errorMessage $ErrorMsg } + if (!$failureDetected) { + Show-PowerValidatedSolutionsOutput -message "Connecting VI Workload Domains to $logsProductName" + foreach ($sddcDomain in $allWorkloadDomains) { + if ($sddcDomain.type -eq "VI") { + $StatusMsg = Register-vRLIWorkloadDomain -server $jsonInput.sddcManagerFqdn -user $jsonInput.sddcManagerUser -pass $jsonInput.sddcManagerPass -domain $sddcDomain.name -status ENABLED -WarningAction SilentlyContinue -ErrorAction SilentlyContinue -WarningVariable WarnMsg -ErrorVariable ErrorMsg + messageHandler -statusMessage $StatusMsg -warningMessage $WarnMsg -errorMessage $ErrorMsg; if ($ErrorMsg) { $failureDetected = $true } + } + } + } + if (!$failureDetected) { Show-PowerValidatedSolutionsOutput -message "Configuring the NSX Edge Nodes to Forward Log Events to $logsProductName" foreach ($sddcDomain in $allWorkloadDomains) { @@ -13017,16 +13027,6 @@ Function Invoke-IlaDeployment { messageHandler -statusMessage $StatusMsg -warningMessage $WarnMsg -errorMessage $ErrorMsg; if ($ErrorMsg) { $failureDetected = $true } } - if (!$failureDetected) { - Show-PowerValidatedSolutionsOutput -message "Connecting VI Workload Domains to $logsProductName" - foreach ($sddcDomain in $allWorkloadDomains) { - if ($sddcDomain.type -eq "VI") { - $StatusMsg = Register-vRLIWorkloadDomain -server $jsonInput.sddcManagerFqdn -user $jsonInput.sddcManagerUser -pass $jsonInput.sddcManagerPass -domain $sddcDomain.name -status ENABLED -WarningAction SilentlyContinue -ErrorAction SilentlyContinue -WarningVariable WarnMsg -ErrorVariable ErrorMsg - messageHandler -statusMessage $StatusMsg -warningMessage $WarnMsg -errorMessage $ErrorMsg; if ($ErrorMsg) { $failureDetected = $true } - } - } - } - if (!$failureDetected) { Show-PowerValidatedSolutionsOutput -type NOTE -message "Finished Deployment of $solutionName" }