Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS pre-requisite check fails for HRM #750

Closed
4 tasks done
makolos2 opened this issue Sep 9, 2024 · 1 comment · Fixed by #751
Closed
4 tasks done

DNS pre-requisite check fails for HRM #750

makolos2 opened this issue Sep 9, 2024 · 1 comment · Fixed by #751
Assignees
Labels
bug Bug
Milestone

Comments

@makolos2
Copy link

makolos2 commented Sep 9, 2024

Code of Conduct

  • I have read and agree to the Code of Conduct.
  • Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • Do not leave "+1" or other comments that do not add relevant information or questions.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

VMware Cloud Foundation

5.2

Module Version

2.12.0.1024

PowerShell Version

7.4.5

PowerCLI Version

13.3.0.24145081

PowerVCF Version

2.4.1.1000

Guest Operating System

Windows Server 2019

Environment Details

No response

Description

When running Pre-requisite checks for HRM, the following error appears:
[ERROR] Forward Lookup: (sfo-m01-hrm01.sfo.rainpole.io) resolved to () using DNS server (10.11.10.4 10.11.10.5): FAILED.
However, DNS resolution is OK.
Instead, the issue is that the JSON file is generated with a space between region_dns1_ip and region_dns2_ip (line 26605 of PowerValidateSolutions.psm1), but the pre-requisite checker splits the field back into 2 source IPs based on ",", so the full string is returned, which is not an IP and thus the check fails.

This also may be an issue with the Site Protection and Disaster Recovery as it too generates JSON with a space separating the DNS IPs (line 2687), however in that case the test also uses a " " to split the entries (line 2843). That should probably also be aligned to use "," which is what all the other solutions appear to use, for sake of consistency.

Error or Debug Output

[ERROR] Forward Lookup: (sfo-m01-hrm01.sfo.rainpole.io) resolved to () using DNS server (10.11.10.4 10.11.10.5): FAILED.

Expected Behavior

DNS pre-requisite check should pass when DNS is correct

Actual Behavior

Test will fail if there is more than one DNS server IP in input.

Steps to Reproduce

Simply generate JSON for HRM using default values, then pre-req tests.

Log Fragments and Files

No response

Screenshots

No response

References

No response

@makolos2 makolos2 added bug Bug needs-triage Needs Triage labels Sep 9, 2024
@github-actions github-actions bot added the pending-review Pending Review label Sep 9, 2024
@tenthirtyam tenthirtyam removed pending-review Pending Review needs-triage Needs Triage labels Sep 10, 2024
@tenthirtyam tenthirtyam added this to the v2.12.0 milestone Sep 10, 2024
@tenthirtyam tenthirtyam mentioned this issue Sep 10, 2024
11 tasks
Copy link

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants