Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance add-nsxtidentitysourc to validate ad credentials #559

Conversation

GaryJBlake
Copy link
Contributor

@GaryJBlake GaryJBlake commented Apr 5, 2024

Summary

  • Fixed Test-ADAuthentication cmdlet to pass failure message as an output rather than error message so it can be evaluated.
  • Enhanced Add-NsxtIdentitySource cmdlet to verify the Active Directory credentials are valid.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #558

Additional Information

N/A

- Fixed `Test-ADAuthentication` cmdlet to pass failure message as an output rather than error message so it can be evaluated.
- Enhanced `Add-NsxtIdentitySource` cmdlet to verify the Active Directory credentials are valid.

Signed-off-by: Gary Blake <gblake@vmware.com>
@GaryJBlake GaryJBlake requested a review from a team as a code owner April 5, 2024 08:36
@GaryJBlake GaryJBlake self-assigned this Apr 5, 2024
@GaryJBlake GaryJBlake added enhancement Enhancement vvs/iam Identity and Access Management labels Apr 5, 2024
@GaryJBlake GaryJBlake added this to the v2.10.0 milestone Apr 5, 2024
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Apr 5, 2024
@GaryJBlake GaryJBlake removed the needs-review Needs Review label Apr 5, 2024
@GaryJBlake GaryJBlake merged commit b291984 into develop Apr 5, 2024
3 checks passed
@GaryJBlake GaryJBlake deleted the feat-enhance-add-nsxtidentitysourc-to-validate-ad-credentials branch April 5, 2024 08:40
Copy link

github-actions bot commented May 6, 2024

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required documentation Documentation enhancement Enhancement vvs/iam Identity and Access Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Add-NsxtIdentitySource to check for the existence of the AD service account
2 participants