Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dns prereqs #751

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

andybeltz
Copy link
Contributor

@andybeltz andybeltz commented Sep 9, 2024

Summary

  • Fixed Export-HrmJsonSpec cmdlet to add the DNS servers with a "," in place of a space for consistency with other JSON specs.
  • Fixed Export-PdrJsonSpec cmdlet to add the DNS servers with a "," in place of a space for consistency with other JSON specs.
  • Fixed Test-PdrPrerequisite cmdlet to split the DNS servers with a "," in place of a space for consistency with other test pre req functions.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #750

Additional Information

- Fixed `Export-HrmJsonSpec` cmdlet to add the DNS servers with a "," in place of a space for consistency with other JSON specs.
- Fixed `Export-PdrJsonSpec` cmdlet to add the DNS servers with a "," in place of a space for consistency with other JSON specs.
- Fixed `Test-PdrPrerequisite` cmdlet to split the DNS servers with a "," in place of a space for consistency with other test pre req functions.

Signed-off-by: Andy Beltz <andy.beltz@broadcom.com>
@andybeltz andybeltz requested a review from a team as a code owner September 9, 2024 17:43
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Sep 9, 2024
@tenthirtyam tenthirtyam added bug Bug and removed documentation Documentation labels Sep 10, 2024
@tenthirtyam tenthirtyam added this to the v2.12.0 milestone Sep 10, 2024
@github-actions github-actions bot added the documentation Documentation label Sep 10, 2024
@tenthirtyam tenthirtyam changed the title chore:fix-dns-in-prereqs fix: dns in prereqs Sep 10, 2024
@tenthirtyam tenthirtyam changed the title fix: dns in prereqs fix: dns prereqs Sep 10, 2024
@tenthirtyam tenthirtyam merged commit f8e97d3 into vmware:develop Sep 10, 2024
9 checks passed
@andybeltz andybeltz deleted the chore/fix-dns-in-prereqs branch September 11, 2024 17:51
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Oct 9, 2024
Copy link

github-actions bot commented Nov 9, 2024

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS pre-requisite check fails for HRM
3 participants