feat: enhance pca workflow #752
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kim, could you make these three separate PRs with referenced issues? |
tenthirtyam
force-pushed
the
pca-multi-wld
branch
from
eaab110 to
d9bb6ce
Compare
|
Kim as per Ryan's comment could you split this into three separate PRs so that we can easily roll back. Q. Have you validated these changes against a non-isolated setup in case it breaks something? |
tenthirtyam
force-pushed
the
pca-multi-wld
branch
from
d9bb6ce to
f32f66b
Compare
tenthirtyam
changed the title
PCA workflow previously would only complete when there was a workload domain with a single cluster. To allow for multiple clusters under a workload domain, the code has been enhanced to successfully create the VM folder, resource rools, and tag the resource pools in the Cloud Account. - Changed `Add-VMFolder` to select the first cluster in a datacenter to create the folder. - Changed `Add-ResourcePool` to select the first cluster in a workload domain in case a cluster is not specified as parameter. - Changed `Update-vRACloudAccountZone` to allow add multiple resource pools to the cloud account. Parameter `ResoucePool` which was a concatenation of `Cluster` and `Resourcepool` is now entered as only the suffix, and built during the for loop.
tenthirtyam
force-pushed
the
pca-multi-wld
branch
from
f32f66b to
483d668
Compare
|
@maxiepax - any chance that you could update this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PCA workflow previously would only complete when there was a workload domain with a single cluster.
To allow for multiple clusters under a workload domain, the code has been enhanced to successfully create the VM folder, resource rools, and tag the resource pools in the Cloud Account.
Add-VMFolderto select the first cluster in a datacenter to create the folder.Add-ResourcePoolto select the first cluster in a workload domain in case a cluster is not specified as parameter.Update-vRACloudAccountZoneto allow add multiple resource pools to the cloud account. ParameterResoucePoolwhich was a concatenation ofClusterandResourcepoolis now entered as only the suffix, and built during the for loop.Type
Please describe:
Breaking Changes?
There was no other functions that used -Resourcepool as input for the Update-vRACloudAccountZone function, thus i deem it non-breaking to change the param name.
Test and Documentation
Tests where conducted using a Standard Architecture with a Workload domain, with two clusters.
Issue References
Additional Information