Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed IAC-597 #139

Closed
wants to merge 1 commit into from
Closed

Fixed IAC-597 #139

wants to merge 1 commit into from

Conversation

akumanov-vmw
Copy link
Contributor

@akumanov-vmw akumanov-vmw commented Dec 7, 2023 •
edited
Loading

Description

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have tested against live vRO/vRA, if applicable
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Screenshot

Related issues and PRs

@akumanov-vmw akumanov-vmw requested a review from a team as a code owner December 7, 2023 13:58
@vmwclabot
Copy link
Member

@akumanov-vmw, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Michaelpalacce
Michaelpalacce reviewed Dec 7, 2023
View reviewed changes
packages/node/vrdt-common/src/maven/MavenCliProxy.ts
@@ -110,7 +110,7 @@ export class MavenCliProxy {
const content = fs.readFileSync(filePath, { encoding: "utf8" })
const token = JSON.parse(content)

if (!token || !token.value || !token.expirationDate) {
if (!token || !token.value) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelpalacce Michaelpalacce Michaelpalacce left review comments

Assignees
No one assigned
Labels
dco-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akumanov-vmw @vmwclabot @Michaelpalacce