Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IAC-597 #140

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fixed IAC-597 #140

merged 1 commit into from
Dec 7, 2023

Conversation

akumanov-vmw
Copy link
Contributor

@akumanov-vmw akumanov-vmw commented Dec 7, 2023

Description

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have tested against live vRO/vRA, if applicable
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Screenshot

Related issues and PRs

Signed-off-by: Aleksandar Kumanov <akumanov@vmware.com>
Copy link
Collaborator

@Michaelpalacce Michaelpalacce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akumanov-vmw akumanov-vmw requested review from VenelinBakalov and a team December 7, 2023 15:05
@akumanov-vmw akumanov-vmw self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #140 (72fd198) into master (a8c831d) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   54.21%   54.21%           
=======================================
  Files          40       40           
  Lines         806      806           
  Branches      117      117           
=======================================
  Hits          437      437           
  Misses        331      331           
  Partials       38       38           

@akumanov-vmw akumanov-vmw merged commit 08a539a into master Dec 7, 2023
15 of 17 checks passed
@akumanov-vmw akumanov-vmw deleted the IAC-597-fix-run-action-failure branch December 7, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants