Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAC-805 Lazy Load of vRO Inventory Items #142

Merged
merged 10 commits into from
Feb 14, 2024

Conversation

akantchev
Copy link
Contributor

@akantchev akantchev commented Jan 16, 2024

Description

In order not to overload the vRO with REST requests to the inventory items REST endpoint in the vRO (on heavily loaded environment) a vRO inventory caching feature has been implemented that loads the inventory items lazy and caches during the visual studio session runtime. The vRO data collection is executed in serial order (in order not to overload the vRO with a lot of parallel REST requests).

Checklist

  • Lint and unit tests pass locally with my changes
  • I have tested against live vRO/vRA, if applicable
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Run the plugin against a real vRO environment, the action hinting should be fetched once thus fetching data only once, further REST request will be made until the refresh button is clicked or the IDE is reloaded. The vRO's vco micro service should not get overloaded with REST requests and no request are getting dropped.

Release Notes

  • Auto caching of vRO inventory items during initial IDE load (if the caching setting is enabled).
  • The caching behavior may be disabled via the vrdev.vro.inventory.cache plugin setting. By default the setting is set to true
  • vRO data collection REST requests are done serially for each of the category items.

Related Issues

#137

Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
@akantchev akantchev requested a review from a team as a code owner January 16, 2024 15:06
@akantchev akantchev marked this pull request as draft January 16, 2024 15:41
@akantchev akantchev self-assigned this Jan 17, 2024
…ces, configurations

Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
@akantchev akantchev marked this pull request as ready for review January 17, 2024 15:19
…ventory cache

Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
@vmware vmware deleted a comment from codecov bot Jan 18, 2024
Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
@akantchev akantchev changed the title IAC-805 Add Lazy Load for vRO Categories and Hint Actions IAC-805 Lazy Load of vRO Inventory Items Jan 18, 2024
…toring

Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
…rder in order not to overload vRO, code refactoring

Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Merging #142 (0171aef) into master (60bd232) will increase coverage by 0.13%.
The diff coverage is 25.00%.

❗ Current head 0171aef differs from pull request most recent head 691d499. Consider uploading reports for the commit 691d499 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   54.21%   54.35%   +0.13%     
==========================================
  Files          40       40              
  Lines         806      804       -2     
  Branches      117      116       -1     
==========================================
  Hits          437      437              
+ Misses        331      330       -1     
+ Partials       38       37       -1     

Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
Signed-off-by: Alexander Kantchev <akantchev@vmware.com>
@akantchev akantchev merged commit 9b109bd into master Feb 14, 2024
13 checks passed
@akantchev akantchev deleted the IAC-805-lazy-load-vro-categories branch February 14, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants