Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(154) Change vrdev.buildTools.defaultVersion extension configuration scope to resource #156

Conversation

VenelinBakalov
Copy link
Collaborator

@VenelinBakalov VenelinBakalov commented Jul 31, 2024

Description

Change vrdev.buildTools.defaultVersion extension configuration scope to resource. This enables the setting to be configured on user settings level, workspace level and local file level.

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have tested against live vRO/vRA, if applicable
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Screenshot

Related issues and PRs

#154

@vmwclabot
Copy link
Member

@VenelinBakalov, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@VenelinBakalov VenelinBakalov merged commit 7b5adb2 into master Aug 2, 2024
5 checks passed
@VenelinBakalov VenelinBakalov deleted the 154-allow-vrdevbuildtoolsdefaultversion-to-be-overridden-by-vscodesettingsjson branch August 2, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow vrdev.buildTools.defaultVersion to be overridden by .vscode/settings.json
3 participants