all: minor cleanups spotted by unparam

subpub/subpub.go

@@ -117,16 +117,14 @@ func (s *SubPub) listen(receiver chan<- *Message) {
 }
 
 // Close terminates the subpub networking stack
-func (s *SubPub) Close() error {
+func (s *SubPub) Close() {
 	log.Debug("received close signal")
 	select {
 	case <-s.close:
 		// already closed
-		return nil
 	default:
 		close(s.close)
 		close(s.messages)
-		return nil
 	}
 }
 

vochain/app.go

@@ -129,14 +129,11 @@ func NewBaseApplication(dbType, dbpath string) (*BaseApplication, error) {
 	istc := ist.NewISTC(state)
 
 	// Create the transaction handler for checking and processing transactions
-	transactionHandler, err := transaction.NewTransactionHandler(
+	transactionHandler := transaction.NewTransactionHandler(
 		state,
 		istc,
 		filepath.Join(dbpath, "txHandler"),
 	)
-	if err != nil {
-		return nil, fmt.Errorf("cannot create transaction handler: (%v)", err)
-	}
 	// Load or download the zk verification keys
 	if err := transactionHandler.LoadZkCircuit(circuit.DefaultCircuitConfigurationTag); err != nil {
 		return nil, fmt.Errorf("cannot load zk circuit: %w", err)

vochain/transaction/transaction.go

@@ -48,12 +48,12 @@ type TransactionHandler struct {
 }
 
 // NewTransactionHandler creates a new TransactionHandler.
-func NewTransactionHandler(state *vstate.State, istc *ist.Controller, dataDir string) (*TransactionHandler, error) {
+func NewTransactionHandler(state *vstate.State, istc *ist.Controller, dataDir string) *TransactionHandler {
 	return &TransactionHandler{
 		state:   state,
 		dataDir: dataDir,
 		istc:    istc,
-	}, nil
+	}
 }
 
 func (t *TransactionHandler) LoadZkCircuit(configTag string) error {