indexer and api: track accounts, balances

[mariajdab]

Note:

The proposal approach use upsert operation to insert or update an account, due the currently approach calls OnSetAccount Listener when an account is created and also when the balance is updated. This approach was tested in the indexer and integration test. Suggestions are welcome.

• SQL changes
• Query for fetching the paginated list of accounts
• Query for fetching the list of token transfers by to_account
• Query to count the number of accounts
• Implement a query to count the number of transfers where the to_account is the provided address and where the from_account is the provided address
• IAPI endpoint and APIclient method /accounts/page/:num
• API endpoint and APIclient method /accounts/count
• API endpoint /accounts/{accountID}/transfers/count to provide the total number of sent and received transactions
• Current API endpoint /accounts/{accountID}/transfers/page/:page extended so it contains the received and sent transfers.
• unit tests of the indexer new queries
• integration tests into test/api_test.go

[coveralls]

Pull Request Test Coverage Report for Build 6786885591

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

• 206 of 340 (60.59%) changed or added relevant lines in 7 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.3%) to 61.728%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
vochain/indexer/db/account.sql.go	21	29	72.41%
vochain/indexer/db/token_transfers.sql.go	25	33	75.76%
cmd/end2endtest/account.go	11	21	52.38%
vochain/indexer/indexer.go	59	69	85.51%
api/accounts.go	63	90	70.0%
vochain/indexer/db/db.go	10	40	25.0%
apiclient/account.go	17	58	29.31%

Totals
Change from base Build 6782737322:	0.3%
Covered Lines:	14548
Relevant Lines:	23568

---

💛 - Coveralls

[mariajdab]

@mvdan could you please review this PR when you have a chance? thanks 🙌

[altergui]

i didn't finish the review yet but leaving here some thought about names

[altergui]

a couple more comments about names consistency, since i see in your commit message:

add new queries in token_transfers: GetTokenTransfersByToAccount, GetTokenTransfersByAccount, CountTokenTransfersByAccount

which sounds excellent and consistent,

yet in the code i see you missed the "By" in GetTokenTransfersAccount, CountTokenTransfersAccount. i pointed out the ones i spotted, maybe there are more

[p4u]

@mariajdab could you resolve and close the pending comments please?

[mariajdab]

@mariajdab could you resolve and close the pending comments please?

Done 🙌

[p4u]

It LGTM, good job @mariajdab

[p4u]

@mvdan it would be nice if you can take a look, however if that's not possible, we'll merge this into main, since other changes to the indexer are pending and would conflict with this one.

[mvdan]

SGTM

[mariajdab]

The last step is: open the issue in Interoperability announcing the changes to the API, so the SDK and documentation can incorporate them. Just to confirm that needs to be done before or after merge this PR ? @p4u

[p4u]

The last step is: open the issue in Interoperability announcing the changes to the API, so the SDK and documentation can incorporate them. Just to confirm that needs to be done before or after merge this PR ? @p4u

You can do it after. Just document the new endpoints so at some point they can be incorporated into the SDK https://github.com/vocdoni/interoperability/issues

[p4u]

I will merge this PR. Thanks for your work @mariajdab