Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/config/services/index.md: Improve wording #632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

camoz
Copy link
Contributor

@camoz camoz commented Dec 22, 2021

AIUI, this bullet point refers to the clean "environment" of a process, and not to the concept of process state (e.g. running/failed/degraded/...).

@camoz
Copy link
Contributor Author

camoz commented Dec 22, 2021

Please review carefully, as I'm quite new to runit.

Also note that after my changes it says "[the service] will be started with the same environment variables". I'm not 100% sure this is correct. But if it is, this wording is more precise IMO.

@ericonr
Copy link
Member

ericonr commented Dec 24, 2021

Looks good, but please fix the commit message to be the same as the PR title.

git commit --amend should allow you to fix the commit message, and then just do git push -f origin patch-1

@camoz
Copy link
Contributor Author

camoz commented Dec 24, 2021

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants