gitoxide: update to 0.27.0. #44936
Merged
gitoxide: update to 0.27.0. #44936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We ran into this issue in nixpkgs, so I patched gitoxide and it has been upstreamed to the main branch: GitoxideLabs/gitoxide#1024 I am not a void user, but if someone wants to re-enable cargo-auditable you can probably do the same thing we did and pull the patch from the PR (it is only tested in version v0.29.0 though). If it doesn't apply to v0.27.0 and you don't want to update, I did leave the reasoning about how the patch was made in the linked issues in the gitoxide PR if someone wants to replicate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
This PR disables cargo-auditable for gitoxide temporarily, as it fails to build when cargo-auditable is used. This is reproducible both within void-packages, as well as when using rustup and building it out of tree.
Reported upstream at rust-secure-code/cargo-auditable#124, although I'm not sure whether it belongs there or with gitoxide. As it's cargo-auditable that's panic'ing, I've opened the issue there.