CCS 4603/CCU-309 #271
Merged
CCS 4603/CCU-309 #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxszym-dolby
commented
Jul 24, 2023
mxszym-dolby
commented
- Fixed React throwing memory leak errors, issue [CCS-4603]. Issue was caused by async actions calling setState() after various components had already unmounted
- Also, changed the way the app handles forcing the user into speaker mode when screen-share is active, so it can properly restore the previous view once the stream has ended (CCU-309). This change also accommodates multiple screen-shares at once.
- Set the video of the active speaker to muted, to avoid hearing 2 audio stream from the same participant
- Now when there is only one person, they will by forced out of speaker mode
…xed the conference not returning to the display mode it was in before screen sharing after stream ends. Also changed the behavior of the speaker mode, so that it mutes the video stream showing the speaker, to avoid mismatch between 2 audio stream coming from the same user
…ing participant left, rendering their avatar as speaker, despite the participant having left the call
kwesi-dolby
approved these changes
Jul 25, 2023
pnowa-dolby
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.