Drop EoL EL7 support #1112
Drop EoL EL7 support #1112
Conversation
REFERENCE.md
Outdated
There was a problem hiding this comment.
why is this file here? shouldn't it be just generated on module release and "gut is"?
There was a problem hiding this comment.
during the release process, we've logic in place to verify that the reference.md is up to date, but it needs to exist.
There was a problem hiding this comment.
🤔 ok
but still, this is "Drop EL7", it doesn't touch anything release-worthy.
Should that be part of #1111?
(yes, nitpicking, sorry)
There was a problem hiding this comment.
In Foreman we generate it as part of the release because IMHO we shouldn't include generated files in git. In Vox people did want that and I didn't have the energy to push back on it though I still hate it
There was a problem hiding this comment.
Can you at least make it a separate commit?
There was a problem hiding this comment.
I moved that comit over to #1111 (people really should not give me push permissions everywhere 😝 )
bastelfreak
force-pushed
the
ol7
branch
2 times, most recently
from
550e1a2 to
1fbf582
Compare
Pull Request (PR) description
This Pull Request (PR) fixes the following issues