Adding SLES to supported platforms #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msurato have you tested on Suse servers? |
|
I have tested this on Suse, but not OpenSuSE. While they should be fine, I
would think we would want to test first. There is an issue with zypprepo
that is affecting the installation (
voxpupuli/puppet-zypprepo#10), but putting in a
work around with installing the certificate with the RPMKey module (
https://forge.puppet.com/stschulte/rpmkey) is not difficult.
If you want, I can test with OpenSuSE and update the pull request. Please
let me know what you think! Thanks!
…On Sun, Oct 28, 2018 at 4:45 AM Florian CHARDIN ***@***.***> wrote:
@msurato <https://github.com/msurato> have you tested on Suse servers?
Why not adding some acceptance test for OpenSuSE?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#893 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZUMuyZ_aUuaZqilt9bapVvnaquqjxN8ks5upW6TgaJpZM4X0PXd>
.
|
|
+1 for this. We are using the module on SLES12 and it works (like on Rhel/Ubuntu OS). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues