only ensure real npm packages

nodesource's `nodejs` packages have `Provides: npm` which means that when we try to `ensure => absent` the `npm` package, it really removes the `nodejs` package we want. by setting `allow_virtual => false` we ensure that we only remove real packages. Fixes: 160ea93
voxpupuli · Oct 28, 2023 · c2d5e79 · c2d5e79
1 parent ff1fd3f
commit c2d5e79
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/manifests/install.pp b/manifests/install.pp
@@ -46,8 +46,9 @@
   # npm
   if $nodejs::npm_package_name and $nodejs::npm_package_name != false {
     package { $nodejs::npm_package_name:
-      ensure => $nodejs::npm_package_ensure,
-      tag    => 'nodesource_repo',
+      ensure        => $nodejs::npm_package_ensure,
+      allow_virtual => false,
+      tag           => 'nodesource_repo',
     }
   }
 

diff --git a/manifests/params.pp b/manifests/params.pp
@@ -41,7 +41,7 @@
       $nodejs_dev_package_name   = 'nodejs-devel'
       $nodejs_dev_package_ensure = 'absent'
       $nodejs_package_name       = 'nodejs'
-      $npm_package_ensure        = 'present'
+      $npm_package_ensure        = 'absent'
       $npm_package_name          = 'npm'
       $npm_path                  = '/usr/bin/npm'
       $repo_class                = 'nodejs::repo::nodesource'