Skip to content

Fix handling of request extensions in x509_cert type and provider #119

Fix handling of request extensions in x509_cert type and provider

Fix handling of request extensions in x509_cert type and provider #119

Triggered via pull request March 27, 2024 13:31
@rtibrtib
synchronize #180
rtib:req_ext
Status Failure
Total duration 1m 38s
Artifacts

ci.yml

on: pull_request
Puppet  /  Static validations
20s
Puppet / Static validations
Matrix: Puppet / unit
Puppet  /  Test suite
0s
Puppet / Test suite
Fit to window
Zoom out
Zoom in

Annotations

4 errors
Puppet / 7 (Ruby 2.7): spec/unit/puppet/type/x509_cert_spec.rb#L57
Puppet::Type::X509_cert accepts a valid req_ext parameter Failure/Error: expect(resource[:req_ext]).to eq(:true) expected: :true got: true (compared using ==) Diff: @@ -1 +1 @@ -:true +true
Puppet / 7 (Ruby 2.7): spec/unit/puppet/type/x509_cert_spec.rb#L62
Puppet::Type::X509_cert does not accept a bad req_ext parameter Failure/Error: expect do resource[:req_ext] = :foo end.to raise_error(Puppet::Error, %r{Invalid value :foo}) expected Puppet::Error with message matching /Invalid value :foo/ but nothing was raised
Puppet / 7 (Ruby 2.7): spec/unit/puppet/provider/x509_cert/openssl_spec.rb#L62
The openssl provider for the x509_cert type when using a CA for signing creates a certificate with the proper options Failure/Error: openssl options #<Puppet::Type::X509_cert::ProviderOpenssl (class)> received :openssl with unexpected arguments expected: (["x509", "-req", "-days", 3650, "-in", "/tmp/foo.csr", "-out", "/tmp/foo.crt", "-extfile", "/tmp/foo....reateserial"], ["-CA", "/tmp/foo-ca.crt"], ["-CAkey", "/tmp/foo-ca.key"], ["-extensions", "v3_req"]]) got: (["x509", "-req", "-days", 3650, "-in", "/tmp/foo.csr", "-signkey", "/tmp/foo.key", "-out", "/tmp/foo....reateserial"], ["-CA", "/tmp/foo-ca.crt"], ["-CAkey", "/tmp/foo-ca.key"], ["-extensions", "v3_req"]])
Puppet / 7 (Ruby 2.7)
Process completed with exit code 1.