export/{pem_cert,pem_key,pkcs12}: passin, passout: use shellquote() instead of single quotation marks
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelkovtunov
changed the title
kenyon
reviewed
Jun 24, 2024
There was a problem hiding this comment.
I think the purpose of the single quotation marks was to guard against shell metacharacters being in the password, since this is passed to a command line. What about using https://www.puppet.com/docs/puppet/latest/function.html#shellquote instead?
Tested the latest commit on my deployment, seems to work fine. |
kenyon
changed the title
passin, passout: use shellquote() instead of single quotation marks
kenyon
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Remove unnecessary single quotes for passin and passout parameter.
Also fixes a bug, where the quotation is interpreted as a part of the password