Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tls-version-min #264

Open
peterbeck opened this issue Feb 18, 2018 · 3 comments
Open

Adding tls-version-min #264

peterbeck opened this issue Feb 18, 2018 · 3 comments

Comments

@peterbeck
Copy link
Contributor

Hey there,

I am a longtime user of this module. But I've used quiet an old version so I did an upgrade, as so much was added / changed. Most of my servers are still running with Debian Jessie (8.x, soon to be upgraded).

It seems I can't connect with the current defaults - getting following message

SSL routines:SSL3_GET_CLIENT_HELLO:no shared cipher

when commenting tls-cipher in the server- and client config, it does work, but of course this is not what I intend to do.

But when adding tls-version-min on the server config, it seems to work flawless again

tls-version-min 1.2

Could we add these options for the server config ? Shall I create a pull request with that addition ?
As this is also recommended in the hardening manual, I think this would be reasonable.

Regards
Peter

@bastelfreak
Copy link
Member

Hi @peterbeck, thanks for this issue. Can you provide a PR for this?

@peterbeck
Copy link
Contributor Author

Hi @bastelfreak, of course, will do tomorrow. What do you think, defaults to an empty string / unset, so that existing deployments aren't impaired ?

@peterbeck
Copy link
Contributor Author

I've made a pull request - hope I've done it the right way ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants