modulesync 2.10.1

[dhoppe]

No description provided.

[dhoppe]

Ubuntu uses a different name for the interface:

• https://github.com/camptocamp/facterdb/blob/master/facts/3.11/ubuntu-18.04-x86_64.facts#L255

@bastelfreak Do we want to use $facts['networking']['ip'] to fix the CI pipeline? This would also fix #263 and the user is still able to override the value of $local at manifests/server.pp.

[dhoppe]

The tests are still failing, because Facer 3.14 provides the wrong hostname, domain and fqdn for Arch Linux. I have fixed this via voxpupuli/facterdb#146.

Failures:

  1) openvpn::client on archlinux-5-x86_64 setting the minimum parameters is expected to contain File[/etc/openvpn/test_server/download-configs/test_client/test_client.conf] with content =~ /^remote\s+foo.example.com\s+1194$/
     Failure/Error: it { is_expected.to contain_file('/etc/openvpn/test_server/download-configs/test_client/test_client.conf').with_content(%r{^remote\s+foo.example.com\s+1194$}) }

       expected that the catalogue would contain File[/etc/openvpn/test_server/download-configs/test_client/test_client.conf] with content set to /^remote\s+foo.example.com\s+1194$/ but it is set to "client\ndev tun\nproto tcp\nremote archlinux 1194\ncomp-lzo\nresolv-retry infinite\nauth-retry none\nnobind\npersist-key\npersist-tun\ncipher AES-256-CBC\ntls-cipher TLS-DHE-RSA-WITH-AES-256-GCM-SHA384:TLS-DHE-RSA-WITH-AES-256-CBC-SHA256:TLS-DHE-RSA-WITH-AES-128-GCM-SHA256:TLS-DHE-RSA-WITH-AES-128-CBC-SHA256\nmute-replay-warnings\nns-cert-type server\nverb 3\nmute 20\n\n# Additional custom options\n\nca keys/test_client/ca.crt\ncert keys/test_client/test_client.crt\nkey keys/test_client/test_client.key\n"
       Diff:
       @@ -1,2 +1,23 @@
       -(?-mix:^remote\s+foo.example.com\s+1194$)
       +client
       +dev tun
       +proto tcp
       +remote archlinux 1194
       +comp-lzo
       +resolv-retry infinite
       +auth-retry none
       +nobind
       +persist-key
       +persist-tun
       +cipher AES-256-CBC
       +tls-cipher TLS-DHE-RSA-WITH-AES-256-GCM-SHA384:TLS-DHE-RSA-WITH-AES-256-CBC-SHA256:TLS-DHE-RSA-WITH-AES-128-GCM-SHA256:TLS-DHE-RSA-WITH-AES-128-CBC-SHA256
       +mute-replay-warnings
       +ns-cert-type server
       +verb 3
       +mute 20
       +
       +# Additional custom options
       +
       +ca keys/test_client/ca.crt
       +cert keys/test_client/test_client.crt
       +key keys/test_client/test_client.key

     # ./spec/defines/openvpn_client_spec.rb:80:in `block (5 levels) in <top (required)>'

Finished in 1 minute 35.6 seconds (files took 32.72 seconds to load)
612 examples, 1 failure

Failed examples:

rspec './spec/defines/openvpn_client_spec.rb[1:9:7:7]' # openvpn::client on archlinux-5-x86_64 setting the minimum parameters is expected to contain File[/etc/openvpn/test_server/download-configs/test_client/test_client.conf] with content =~ /^remote\s+foo.example.com\s+1194$/