Add rubocop config #130
Merged
Add rubocop config #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me, but RuboCop is not happy with you |
bastelfreak
force-pushed
the
rubocop2
branch
2 times, most recently
from
3d6217c
to
69d21ec
Compare
ekohl
reviewed
Jun 21, 2024
|
@ekohl I merged your PR and rebased. |
bastelfreak
force-pushed
the
rubocop2
branch
5 times, most recently
from
a30cfe7
to
b10b9f1
Compare
ekohl
reviewed
Jun 21, 2024
| require 'puppetlabs_spec_helper/rake_tasks' | ||
|
|
||
| PuppetLint.configuration.log_format = '%{path}:%{line}:%{check}:%{KIND}:%{message}' | ||
| PuppetLint.configuration.log_format = '%<path>s:%<line>s:%<check>s:%<KIND>s:%<message>s' |
There was a problem hiding this comment.
I honestly don't now if puppet-lint understands this format.
There was a problem hiding this comment.
It seems to work fine:
bastelfreak@bastelfreak-nb ~/code/modulesync_config/modules/voxpupuli/puppet-example $ git diff Gemfile manifests/init.pp
diff --git a/Gemfile b/Gemfile
index a4a3b20..3a8a46c 100644
--- a/Gemfile
+++ b/Gemfile
@@ -4,7 +4,8 @@
source ENV['GEM_SOURCE'] || 'https://rubygems.org'
group :test do
- gem 'voxpupuli-test', '~> 7.0', :require => false
+ #gem 'voxpupuli-test', '~> 7.0', :require => false
+ gem 'voxpupuli-test', git: 'https://github.com/bastelfreak/voxpupuli-test', branch: 'rubocop2'
gem 'coveralls', :require => false
gem 'simplecov-console', :require => false
gem 'puppet_metadata', '~> 3.5', :require => false
diff --git a/manifests/init.pp b/manifests/init.pp
index fbf7850..eacd9af 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -1,8 +1,6 @@
# @summary An example class
# @param file
# The file to manage
-# @param content
-# The content in the file
class example (
Stdlib::Absolutepath $file = '/tmp/puppet-example',
String[1] $content = 'Hello World!',
bastelfreak@bastelfreak-nb ~/code/modulesync_config/modules/voxpupuli/puppet-example $
There was a problem hiding this comment.
was asking myself the same (my rubocop plugin wanted to auto fix this every time i opend the file XD) . but if it is tested...
previously this gem only contained a rubocop config that's used in our modules. We didn't run rubocop for the ruby code in this exact gem. This is changed with this commit.
Merged
rwaffen
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously this gem only contained a rubocop config that's used in our modules. We didn't run rubocop for the ruby code in this exact gem. This is changed with this commit.