Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(check:trailing_whitespace): collect all problems, report and then exit #141

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

rwaffen
Copy link
Sponsor Member

@rwaffen rwaffen commented Jul 1, 2024

fixes: #140

…n exit

Signed-off-by: Robert Waffen <rwaffen@gmail.com>
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't quite get used to conventional commits. I'm not sure how this is for others. Wouldn't it be confusing to use it for some, but not all?

Other than that, the implementation looks correct. Just one tiny note.

lib/voxpupuli/test/rake.rb Outdated Show resolved Hide resolved
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
@rwaffen
Copy link
Sponsor Member Author

rwaffen commented Jul 1, 2024

I try to do conventional commits more and more, because in my project people also starting with it and we want somehow build semantic-release upon it. but I'm not really sure about it my self, thou. or like these young people say: "I don't feel the vibe" :D

@ekohl
Copy link
Member

ekohl commented Jul 1, 2024

I'm also looking at towncrier and that it provides a bit more flexibility in its structure. Though you have more "noise" in your git log for files. One advantage is that with GitHub (& GitLab for that matter) you can't comment on commit messages, making it very hard to provide feedback on them. Even if it's for typos.

@ekohl ekohl merged commit 0dcbc9d into voxpupuli:master Jul 2, 2024
9 checks passed
@rwaffen rwaffen deleted the collect_all_offenses branch July 4, 2024 07:32
@rwaffen rwaffen added the enhancement New feature or request label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add option to rake check: find all problems and then fail
2 participants