python/plane-tickets: 3rd iteration - py3.11 - pylint fix

vpayno · Apr 5, 2024 · c757a5f · c757a5f
1 parent 3aad757
commit c757a5f
Show file tree

Hide file tree

Showing 5 changed files with 120 additions and 130 deletions.
diff --git a/python/plane-tickets/.coverage b/python/plane-tickets/.coverage
diff --git a/python/plane-tickets/.coverage.xml b/python/plane-tickets/.coverage.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" ?>
-<coverage version="7.4.0" timestamp="1712287513036" lines-valid="38" lines-covered="38" line-rate="1" branches-valid="12" branches-covered="12" branch-rate="1" complexity="0">
+<coverage version="7.4.0" timestamp="1712288392527" lines-valid="36" lines-covered="36" line-rate="1" branches-valid="12" branches-covered="12" branch-rate="1" complexity="0">
 	<!-- Generated by coverage.py: https://coverage.readthedocs.io/en/7.4.0 -->
 	<!-- Based on https://raw.githubusercontent.com/cobertura/web/master/htdocs/xml/coverage-04.dtd -->
 	<sources>
@@ -31,24 +31,22 @@
 						<line number="40" hits="1"/>
 						<line number="43" hits="1"/>
 						<line number="59" hits="1"/>
-						<line number="60" hits="1"/>
+						<line number="61" hits="1" branch="true" condition-coverage="100% (2/2)"/>
 						<line number="62" hits="1" branch="true" condition-coverage="100% (2/2)"/>
 						<line number="63" hits="1"/>
 						<line number="65" hits="1" branch="true" condition-coverage="100% (2/2)"/>
 						<line number="66" hits="1"/>
-						<line number="68" hits="1" branch="true" condition-coverage="100% (2/2)"/>
-						<line number="69" hits="1"/>
+						<line number="68" hits="1"/>
 						<line number="71" hits="1"/>
-						<line number="74" hits="1"/>
-						<line number="83" hits="1"/>
+						<line number="80" hits="1"/>
+						<line number="81" hits="1"/>
+						<line number="83" hits="1" branch="true" condition-coverage="100% (2/2)"/>
 						<line number="84" hits="1"/>
-						<line number="86" hits="1" branch="true" condition-coverage="100% (2/2)"/>
-						<line number="87" hits="1"/>
+						<line number="86" hits="1"/>
 						<line number="89" hits="1"/>
-						<line number="92" hits="1"/>
-						<line number="102" hits="1" branch="true" condition-coverage="100% (2/2)"/>
-						<line number="103" hits="1"/>
-						<line number="105" hits="1"/>
+						<line number="99" hits="1" branch="true" condition-coverage="100% (2/2)"/>
+						<line number="100" hits="1"/>
+						<line number="102" hits="1"/>
 					</lines>
 				</class>
 			</classes>

diff --git a/python/plane-tickets/generators.py b/python/plane-tickets/generators.py
@@ -56,12 +56,9 @@ def generate_seats(quantity: QuantityT) -> Generator[SeatT, Any, Any]:
     Example: 3C, 3D, 4A, 4B
     """
 
-    letter: Generator[LetterT, Any, Any] = generate_seat_letters(quantity)
     row: RowT = 0
 
-    for _ in range(1, quantity + 1):
-        seat: SeatT = next(letter)
-
+    for seat in generate_seat_letters(quantity):
         if seat == "A":
             row += 1
 

diff --git a/python/plane-tickets/generators.py,cover b/python/plane-tickets/generators.py,cover
@@ -56,12 +56,9 @@
 >     Example: 3C, 3D, 4A, 4B
 >     """
 
->     letter: Generator[LetterT, Any, Any] = generate_seat_letters(quantity)
 >     row: RowT = 0
 
->     for _ in range(1, quantity + 1):
->         seat: SeatT = next(letter)
-
+>     for seat in generate_seat_letters(quantity):
 >         if seat == "A":
 >             row += 1