.NET 8 support with keeping compatibility with .NET 6 only environment #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatawa12
commented
Sep 29, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>net6.0</TargetFramework> | |||
| <TargetFrameworks>net6.0;net8.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Simply replacing with <TargetFramework>net8.0</TargetFramework> will break comaptibility with self-hosted runners without .NET 8.
This repository doesn't have versioning so we cannot make breaking change so I added support for .net 8 instead of replading with .NET 8.
lereldarion
added a commit
to lereldarion/vpm-listing
that referenced
this pull request
Oct 13, 2024
Use antawa12 PR branch for now, as the vrchat action is broken currently. See vrchat-community/package-list-action#28
|
this needs to be merged, everyones runners have started breaking including mine which is forked from this repo |
Happyrobot33
added a commit
to Happyrobot33/package-list-action
that referenced
this pull request
Oct 14, 2024
manually merge in this PR to fix my runners vrchat-community#28
|
I had to force the runner to be 24.04, as it still defaulted to 22.04 on Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Improves vrchat-community/template-package#22.
Real run with this fork: https://github.com/anatawa12/vpm-repository-for-package-listing-action-bug-report/actions/runs/11093816442/job/30820561252