Update to CRS v4.1 #132
Closed
Update to CRS v4.1 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to see if my fix for the dockerfile privilege gaining and dropping actually works, so if someone could approve the workflow, that would be good. (it works locally of course 😉 ) |
|
In hindsight, it might make sense to keep v3.3 and v4.x in the same repository, so this PR might not even be sensible to merge. I will convert it to a draft accordingly. |
|
Hi @hellerbarde, good question regarding v3.3 vs v4; I'm not sure yet whether we actually still need the v3 images once we migrated the existing setup. I have approved the workflow; I'll check if I can give you more permanent permissions to run workflows |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was made aware of the failing pipeline for a renovatebot PR: https://github.com/vshn/modsecurity-docker/actions/runs/8677769722 by Mark Zeman.
Upstream made the image rootless with a recent (3 weeks ago) commit and that breaks the invocations of apt tools in this docker file.
I replaced all the occurrences of 3.3 with 4.1 as best I could, but I'm fairly certain there is some more work to be done here, but maybe someone can use this PR/Branch as a jumping off point, or help me fix the rest of the issues.
In particular I'm worried about this file:
v4.1/transform-alert-message.awkAnd some of the custom rules in
custom-rules/might need to be reworked for compatibility with v4.1cheers,
Phil