Skip to content

Commit

Permalink
pythongh-111139: Optimize math.gcd(int, int)
Browse files Browse the repository at this point in the history
Add a fast-path for the common case.

Benchmark:

    python -m pyperf timeit \
        -s 'import math; gcd=math.gcd; x=2*3; y=3*5' \
        'gcd(x,y)'

Result: 1.07x faster (-3.4 ns)

    Mean +- std dev: 52.6 ns +- 4.0 ns -> 49.2 ns +- 0.4 ns: 1.07x faster
  • Loading branch information
vstinner committed Jan 10, 2024
1 parent beb80d1 commit a7049b2
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions Modules/mathmodule.c
Original file line number Diff line number Diff line change
Expand Up @@ -759,13 +759,20 @@ m_log10(double x)
static PyObject *
math_gcd(PyObject *module, PyObject * const *args, Py_ssize_t nargs)
{
PyObject *res, *x;
Py_ssize_t i;
// Fast-path for the common case: avoid calling _PyNumber_Index()
// and the loop.
if (nargs == 2
&& PyLong_CheckExact(args[0])
&& PyLong_CheckExact(args[1]))
{
return _PyLong_GCD(args[0], args[1]);
}

if (nargs == 0) {
return PyLong_FromLong(0);
}
res = PyNumber_Index(args[0]);

PyObject *res = PyNumber_Index(args[0]);
if (res == NULL) {
return NULL;
}
Expand All @@ -775,8 +782,8 @@ math_gcd(PyObject *module, PyObject * const *args, Py_ssize_t nargs)
}

PyObject *one = _PyLong_GetOne(); // borrowed ref
for (i = 1; i < nargs; i++) {
x = _PyNumber_Index(args[i]);
for (Py_ssize_t i = 1; i < nargs; i++) {
PyObject *x = _PyNumber_Index(args[i]);
if (x == NULL) {
Py_DECREF(res);
return NULL;
Expand Down

0 comments on commit a7049b2

Please sign in to comment.