Fix: getPaymentInfo only returning one payment method

[iago1501]

What problem is this solving?

In orders where the bank invoice payment method wasn't the first payment of the first transaction, its information wasn't displayed on the order placed page

How should this be manually tested?

There are 2 use cases for this change:

• Orders with a single transaction with multiple payments, in which one of them is a bank invoice and it isn't in the first position of the payments array;
• Orders with multiple transactions in which one of them has a bank invoice payment, and this transaction isn't the first of the array.

Screenshots or example usage

Example of an order with a bank invoice in the second payment of the array, where its information is not displayed:
https://gaboulstore.myvtex.com/checkout/orderPlaced/?og=1486610500025

Example of the same order, but in a workspace with this change implemented:
https://iespinoza2--gaboulstore.myvtex.com/checkout/orderPlaced/?og=1486610500025

Just a disclaimer, since this bank invoice doesn't have a URL, I just removed this validation in the workspace because I didn't have any other example to test

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Requires change to documentation, which has been updated accordingly.

With this solution I think we might close: #199

[vtex-io-docs-bot]

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

• There's nothing new to document 🤔
• I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

• I just updated 🎉🎉

[vtex-io-ci-cd]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

• Patch (backwards-compatible bug fixes)

• Minor (backwards-compatible functionality)

• Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

• No thanks, I would rather do it manually 😞

[vsseixaso]

In this workspace, bank invoice is the second element, is there a problem with this order?

[iago1501]

In this workspace, bank invoice is the second element, is there a problem with this order?

This is literally what's causing the issue, when a payment method is split (bank invoice and gift card), bank invoice might be the second element. In the previous implementation, the bank invoice method wasn't recognized, in this new approach, since we now check all payment methods, now we are able to find it

[vtex-io-ci-cd]

Your PR has been merged! App is being published. 🚀
Version 2.18.0 → 2.19.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.order-placed@2.19.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖