Configurable thumbnail dimensions in product gallery #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
This PR adds the ability to configure the width and height of product thumbnails in the carousel component. By allowing control over the thumbnail dimensions, this can improve page performance and SEO by ensuring that appropriately sized images are used, reducing unnecessary data loading.
How to test it?
You can test this feature by setting custom values for thumbCustomWidth and thumbCustomHeight in the product image gallery component. Ensure that thumbnails are resized correctly based on these values, and monitor the impact on page load times and SEO scores.
For test use this Workspace
Screenshots or example usage:
In production:
Official component in production unable to set thumbnail size.
See props: Product Image
In workspace:
can be able to set values in px from props component:
Describe alternatives you've considered, if any.
An alternative approach considered was to use CSS only for thumbnail resizing, but this would not allow for dynamic configuration through props or tailored image dimensions for performance.
Related to / Depends on
No dependencies.