Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalogAttributes field to biggysku and attributes field to items #28

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

LucasTornai
Copy link
Member

What problem is this solving?

Adding these fields for the informative sku attributes initiative for hearst.
Basically we added a new field "catalogAttributes" on the skus in the search-api, and we need to transform it to the field "attributes" inside the items for the final product. The objects have the same fields.

How should this be manually tested?

[Workspace]

Checklist/Reminders

  • Updated README.md.
  • Updated CHANGELOG.md.
  • Updated/created tests (important for bug fixes).
  • Deleted the workspace after merging this PR (if applicable).

Screenshots or example usage

Screenshot 2024-02-08 at 11 21 35

Type of changes

✔️ Type of Change
_ Bug fix
✔️ New feature
_ Breaking change
_ Technical improvements

Notes

src/typings/global.ts Outdated Show resolved Hide resolved
src/convertSKU.ts Outdated Show resolved Hide resolved
@LucasTornai LucasTornai merged commit cda5e78 into main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants