Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix product properties for PDP #31

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix product properties for PDP #31

merged 1 commit into from
Mar 18, 2024

Conversation

thalytafabrine
Copy link
Member

What problem is this solving?

We weren't filtering properties properly and adding the metaTagDescription fallback

How should this be manually tested?

Workspace

  • check for metatagDescription property
  • properties array should not contain Clothing Size since it has the flag IsStockKeppingUnit as true

Type of changes

✔️ Type of Change
✔️ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

@thalytafabrine thalytafabrine self-assigned this Mar 12, 2024
@hiagolcm hiagolcm merged commit f5a11b1 into main Mar 18, 2024
1 check passed
@thalytafabrine thalytafabrine deleted the fix/pdp-compatibility branch March 19, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcaula hcaula hcaula approved these changes

@hiagolcm hiagolcm hiagolcm approved these changes

Assignees

@thalytafabrine thalytafabrine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thalytafabrine @hcaula @hiagolcm