Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging new Character Sheets does not Link Token to Sheet #425

Open
1 task done
seansps opened this issue May 10, 2023 · 4 comments
Open
1 task done

Dragging new Character Sheets does not Link Token to Sheet #425

seansps opened this issue May 10, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@seansps
Copy link

seansps commented May 10, 2023

What happened?

  1. Create a new character sheet
  2. Drag the character to the active scene
  3. Notice the token is dropped
  4. Close the sheet
  5. Double click on the token, make a change, close the sheet
  6. Open the original sheet, notice that the change was only applied to the token dropped

What is the expected behaviour?

By default, I'd expect that Character Sheets are always linked back to their Actors. This also makes it so that PCs editing their sheets or setting tokens get updated on the master record.

Relevant Errors and Warnings

No response

Additional Support Details

No response

Foundry VTT Core Version

V10

Old-School Essentials Core Version

Latest

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@seansps seansps added bug Something isn't working triage This bug still needs to be validated and weighted labels May 10, 2023
@justinthejaguar
Copy link

This seems like a core thing where you are missing a step. Only because you did not mention it, are you linking the data on the actor?
Screenshot 2023-05-10 at 8 58 34 AM

@seansps
Copy link
Author

seansps commented May 10, 2023

That could be the case, I don't think I ever clicked that. I am coming from the PF2E system in Foundry, where that is done automatically for users. So, this is probably more of a suggestion than a bug in this case -- but I think perhaps it should be done automatically for Character Sheets as I never see a case where they'd want it to not behave that way. (Less clicking for setting up new characters too, which have a much shorter life span in OSE!)

@justinthejaguar
Copy link

That makes sense, though there are times when encountering other adventuring parties where one might not want to link actors. https://oldschoolessentials.necroticgnome.com/srd/index.php/Adventuring_Parties#Expert_Adventurers.

@anthonyronda
Copy link
Member

Good suggestion (for the default case), I'll happily convert this to an enhancement issue

@anthonyronda anthonyronda added enhancement New feature or request and removed bug Something isn't working triage This bug still needs to be validated and weighted labels May 10, 2023
Stew-rt added a commit to Stew-rt/ose that referenced this issue May 27, 2023
Add default "Link Actor Data" to new Actor's prototypeToken if it's type is character and is not from a Compendium.
Also provided two extra options which would be sane but do not cover the Issue, so commented out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants