Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Secret Text" doesn't work in items. #485

Open
1 task done
osarusan82 opened this issue Nov 20, 2023 · 2 comments
Open
1 task done

"Secret Text" doesn't work in items. #485

osarusan82 opened this issue Nov 20, 2023 · 2 comments
Assignees
Labels
bug Something isn't working character-sheet Related to the character sheet, but not the inventory tab item-sheet Related to the item sheet

Comments

@osarusan82
Copy link

What happened?

When creating an item in the game, text formatted as "secret text" does not show up in the descriptor.

For example, I'll make an item called "Magic Mushrooms" and write "This mushroom looks funny" in the description. Beneath that I'll write a paragraph of DM-only text, like "Eating this heals 1d6 HP" and save it,

The secret text saves properly, but is not visible even to the DM.

What is the expected behaviour?

I would expect the secret text to be visible by the DM in item descriptions, as it is with journal notes.

Relevant Errors and Warnings

No response

Additional Support Details

No response

Foundry VTT Core Version

V11

Old-School Essentials Core Version

1.9.4

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Firefox

Code of Conduct

  • I agree to follow this project's Code of Conduct
@osarusan82 osarusan82 added bug Something isn't working triage This bug still needs to be validated and weighted labels Nov 20, 2023
@monkey-bars
Copy link

Just to note--"secret" text is no longer shown to just the GM once an actor owned by a player has that item in their inventory. What is "secret" only applies to people who don't own the item. The PF2e system has a separate "GM text" field for this purpose, but it's not standard Foundry behaviour.

@anthonyronda
Copy link
Member

See also #430

We've tried to address problems like this with rendering rich text for a while now, and for a while there are hacks/workarounds that (for example) 5e uses to get around Foundry's quirks that for some reason never worked for us

We'll still keep trying

@anthonyronda anthonyronda added character-sheet Related to the character sheet, but not the inventory tab item-sheet Related to the item sheet and removed triage This bug still needs to be validated and weighted labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working character-sheet Related to the character sheet, but not the inventory tab item-sheet Related to the item sheet
Projects
None yet
Development

No branches or pull requests

3 participants