Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to relevant app when inspecting component #748

Merged
merged 5 commits into from
Dec 31, 2024

Conversation

kevinluo201
Copy link
Contributor

@kevinluo201 kevinluo201 commented Dec 19, 2024

Try to fix #718

  • Call toggleApp if the activeAppRecordId is different from the inspected component's app id
  • Add options to toggleApp and related methods, so { inspectingComponent: true } can eventually be sent to core's registerDevToolsPlugin to ignore highPerfModeEnabled

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit efd964f
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/676a3b99e574a60009514e12

@kevinluo201 kevinluo201 marked this pull request as ready for review December 24, 2024 04:45
@kevinluo201
Copy link
Contributor Author

The feature is implemented, however, I added an extra option inspectingComponent at many places. If anyone has a better way to handle this, or to manage the global state, please help me, thanks!

@alexzhang1030 alexzhang1030 changed the title Toggle app when inspecting feat(kit): toggle app when inspecting Dec 24, 2024
@webfansplz webfansplz changed the title feat(kit): toggle app when inspecting fix: switch to relevant app when inspecting component Dec 31, 2024
Copy link

pkg-pr-new bot commented Dec 31, 2024

Open in Stackblitz

@vue/devtools-applet

npm i https://pkg.pr.new/@vue/devtools-applet@748

@vue/devtools-core

npm i https://pkg.pr.new/@vue/devtools-core@748

@vue/devtools

npm i https://pkg.pr.new/@vue/devtools@748

@vue/devtools-api

npm i https://pkg.pr.new/@vue/devtools-api@748

@vue/devtools-kit

npm i https://pkg.pr.new/@vue/devtools-kit@748

vite-plugin-vue-devtools

npm i https://pkg.pr.new/vite-plugin-vue-devtools@748

commit: efd964f

@webfansplz
Copy link
Member

@kevinluo201 Great work, thanks.

@webfansplz webfansplz merged commit a17868a into vuejs:main Dec 31, 2024
7 checks passed
@kevinluo201
Copy link
Contributor Author

kevinluo201 commented Jan 1, 2025

@webfansplz Thanks for the reviewing and merging. Does it solve the issue on the chrome-extension, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot select a component in another App if there are multiple Apps on the page
2 participants