fix(style): always set new styles

close #12901 close #12946
vuejs · Dec 6, 2023 · f5ef882 · f5ef882 · chenyulun · Sep 11, 2024
1 parent d6468c4
commit f5ef882
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/platforms/web/runtime/modules/style.ts b/src/platforms/web/runtime/modules/style.ts
@@ -91,10 +91,8 @@ function updateStyle(oldVnode: VNodeWithData, vnode: VNodeWithData) {
   }
   for (name in newStyle) {
     cur = newStyle[name]
-    if (cur !== oldStyle[name]) {
-      // ie9 setting to null has no effect, must use empty string
-      setProp(el, name, cur == null ? '' : cur)
-    }
+    // ie9 setting to null has no effect, must use empty string
+    setProp(el, name, cur == null ? '' : cur)
   }
 }
 

diff --git a/test/unit/modules/vdom/modules/style.spec.ts b/test/unit/modules/vdom/modules/style.spec.ts
@@ -36,4 +36,19 @@ describe('vdom style module', () => {
     expect(elm.style.fontSize).toBe('')
     expect(elm.style.display).toBe('block')
   })
+
+  it('border related style should update correctly', () => {
+    const vnode1 = new VNode('p', {
+      style: { border: '10px solid red', 'border-bottom': '10px solid blue' }
+    })
+    const vnode2 = new VNode('p', {
+      style: {
+        'border-right': '10px solid red',
+        'border-bottom': '10px solid blue'
+      }
+    })
+    patch(null, vnode1)
+    const elm = patch(vnode1, vnode2)
+    expect(elm.style.borderBottom).toBe('10px solid blue')
+  })
 })