From 1faecfddf2b40733a0654cdaac5752960171d0b4 Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Mon, 13 Nov 2023 08:25:36 -0500
Subject: [PATCH 1/2] Reduce use of substr for readability/performance.

---
 src/VuFindCode/EAN.php  | 8 +++-----
 src/VuFindCode/ISBN.php | 9 ++++-----
 src/VuFindCode/ISMN.php | 2 +-
 3 files changed, 8 insertions(+), 11 deletions(-)

diff --git a/src/VuFindCode/EAN.php b/src/VuFindCode/EAN.php
index c8f7821..89425bd 100644
--- a/src/VuFindCode/EAN.php
+++ b/src/VuFindCode/EAN.php
@@ -92,10 +92,8 @@ public static function getEAN13CheckDigit($ean)
     public static function isValidEAN13($ean)
     {
         $ean = static::normalizeEAN($ean);
-        if (strlen($ean) != 13) {
-            return false;
-        }
-        return
-            substr($ean, 12) == self::getEAN13CheckDigit(substr($ean, 0, 12));
+        return (strlen($ean) != 13)
+            ? false
+            : str_ends_with($ean, self::getEAN13CheckDigit(substr($ean, 0, 12)));
     }
 }
diff --git a/src/VuFindCode/ISBN.php b/src/VuFindCode/ISBN.php
index ce85bec..b6e7ac2 100644
--- a/src/VuFindCode/ISBN.php
+++ b/src/VuFindCode/ISBN.php
@@ -84,7 +84,7 @@ public function get10()
                 return $this->raw;
             } elseif (
                 strlen($this->raw) == 13
-                && substr($this->raw, 0, 3) == '978'
+                && str_starts_with($this->raw, '978')
             ) {
                 // Is it a Bookland EAN?  If so, we can convert to ISBN-10.
                 $start = substr($this->raw, 3, 9);
@@ -176,10 +176,9 @@ public static function getISBN10CheckDigit($isbn)
     public static function isValidISBN10($isbn)
     {
         $isbn = self::normalizeISBN($isbn);
-        if (strlen($isbn) != 10) {
-            return false;
-        }
-        return substr($isbn, 9) == self::getISBN10CheckDigit(substr($isbn, 0, 9));
+        return (strlen($isbn) != 10)
+            ? false
+            : str_ends_with($isbn, self::getISBN10CheckDigit(substr($isbn, 0, 9)));
     }
 
     /**
diff --git a/src/VuFindCode/ISMN.php b/src/VuFindCode/ISMN.php
index 83d219c..3ecde92 100644
--- a/src/VuFindCode/ISMN.php
+++ b/src/VuFindCode/ISMN.php
@@ -83,7 +83,7 @@ public function get10()
                 return $this->raw;
             } elseif (
                 strlen($this->raw) == 13
-                && substr($this->raw, 0, 3) == '979'
+                && str_starts_with($this->raw, '979')
             ) {
                 // Is it a music EAN?  If so, we can convert to ISMN-10.
                 $start = 'M' . substr($this->raw, 4, 8);

From aaab6d1b70f3cfe58082d4e28fa4a57470808c09 Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Mon, 13 Nov 2023 08:27:24 -0500
Subject: [PATCH 2/2] Update CHANGELOG.

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 55af199..fee669c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@ All notable changes to this project will be documented in this file, in reverse
 ### Changed
 
 - The minimum PHP version requirement has been raised to 8.0.
+- The str_starts_with and str_ends_with functions have been used instead of substr where possible.
 
 ### Deprecated