Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop audio when Player position reaches the end of the file #11

Open
lasalillo opened this issue Mar 2, 2022 · 3 comments
Open

Stop audio when Player position reaches the end of the file #11

lasalillo opened this issue Mar 2, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@lasalillo
Copy link

When Loop is off, the Audio player doesn´t stop at the end of the file, it keeps sending the last frame.

Something like that would work.
image

@tebjan
Copy link
Member

tebjan commented Mar 2, 2022

Thanks, yes, it should return silence. but it won't be entirely correct when doing it like shown in the patch because the update isn't synchronized with the audio blocks. so we need to fix that in the c# code of the player in the audio thread.

@tebjan
Copy link
Member

tebjan commented Mar 2, 2022

@lasalillo I just tried that in the AudioPlayer help patch, but it seems to be fine. Can you provide a test patch and file that shows this behavior?

@lasalillo
Copy link
Author

@tebjan I don´t know exactly why but i can´t reproduce it outside my project, probably there are other factors i´m not considering.
I already figured out how to avoid it in my scenario. thanks

@tebjan tebjan added the bug Something isn't working label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants