Add feature for bonding/vlan interface in the firewall_interfaces

[mlk-89]

Add vlan interface in the firewall_interfaces
Add bonding interface in the firewall_interfaces

SUMMARY

When using name that contains a dot in the module vyos_firewall_interfaces , we consider this interface as a vlan interface, so this PR include modification on the facts gathering and config file.

Moreover, set the interface type as well when the name begins with bond.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

plugins/module_utils/network/vyos/config/firewall_interfaces/firewall_interfaces.py
plugins/module_utils/network/vyos/facts/firewall_interfaces/firewall_interfaces.py

ADDITIONAL INFORMATION

Fix this issue: #219

usage:
vyos.vyos.vyos_firewall_interfaces:
config:
- access_rules:
- afi: ipv4
rules:
- name: test1
direction: in
- name: test2
direction: local
name: eth1.10
- access_rules:
- afi: ipv4
rules:
- name: test1
direction: in
- name: test2
direction: local
name: bond0
- access_rules:
- afi: ipv4
rules:
- name: test1
direction: in
- name: test2
direction: local
name: bond0.113

[softwarefactory-project-zuul]

Unable to freeze job graph: Job network-ee-integration-tests-vyos depends on network-ee-build-container-image which was not run.

[GomathiselviS]

@mlk-89 Thanks for working on this. Can you please add relevant test cases to test the fix and a change fragment to explain the fix briefly?

[GomathiselviS]

@mlk-89 Thanks for working on this. Can you please add relevant test cases to test the fix and a change fragment to explain the fix briefly?

[mlk-89]

HI @GomathiselviS, yes sure I can write some tests, can you explain me how the testing environnment works?

Is there already a bonding interface that I can use? or should I create them from other tests?

[GomathiselviS]

@mlk-89 You can add a test case to https://github.com/ansible-collections/vyos.vyos/blob/main/tests/unit/modules/network/vyos/test_vyos_firewall_interfaces.py. The device connection is mocked in the unit tests. You can add a bonding interface config to https://github.com/ansible-collections/vyos.vyos/blob/main/tests/unit/modules/network/vyos/fixtures/vyos_firewall_interfaces_config.cfg and test. Please let me know if you have any queries.