-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[tool]: add node_id
map to source map
#3811
Merged
charles-cooper
merged 23 commits into
vyperlang:master
from
charles-cooper:feat/improved-source-map
Mar 12, 2024
Merged
feat[tool]: add node_id
map to source map
#3811
charles-cooper
merged 23 commits into
vyperlang:master
from
charles-cooper:feat/improved-source-map
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add node_id map to source map, to improve source code integrations for third parties refactor: - get rid of getpos() - rename `IRnode.source_pos` to `IRnode.ast_source` - thread ast_source through to sourcemap generation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3811 +/- ##
==========================================
- Coverage 86.21% 86.20% -0.02%
==========================================
Files 92 92
Lines 13998 14008 +10
Branches 3076 3077 +1
==========================================
+ Hits 12068 12075 +7
- Misses 1494 1496 +2
- Partials 436 437 +1 ☔ View full report in Codecov by Sentry. |
charles-cooper
changed the title
feat[tool]: add node_id map to source map
feat[tool]: add Feb 25, 2024
node_id
map to source map
better handle for public getters
node ids are not unique across modules
remove its node attributes so it doesn't get in the source map
fubuloubu
approved these changes
Mar 11, 2024
cyberthirst
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add node_id map to source map which links directly back to the AST output to improve source code integrations for third parties
refactor:
IRnode.source_pos
toIRnode.ast_source
i also rewrote the source map compression routine a bit. it might have gotten broken but at this point i don't think anybody really uses the compressed source map (i checked with ape and hardhat here and waiting to hear back from slither), they prefer the other formats.
other major tooling:
fixes #1609
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture