-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: parametrize CI over EVM versions #3842
test: parametrize CI over EVM versions #3842
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3842 +/- ##
==========================================
+ Coverage 86.19% 86.21% +0.02%
==========================================
Files 92 92
Lines 14013 14013
Branches 3078 3078
==========================================
+ Hits 12079 12082 +3
+ Misses 1497 1493 -4
- Partials 437 438 +1 ☔ View full report in Codecov by Sentry. |
also remove tox rule for `test`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One fix suggested, also the two CodeQL notes about importing a constant can be dismissed?
one of the codeql notes (https://github.com/vyperlang/vyper/security/code-scanning/1326):
it's kind of interesting, because DEFAULT_EVM_VERSION is actually unused, but it was not picked up by any linter before. anyway, i'll remove it. |
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture