Fixed the Incorrect error messages during compilation #3994. #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberthirst
reviewed
Nov 5, 2024
| @@ -1440,7 +1440,7 @@ def validate(self): | |||
|
|
|||
| if not self.is_constant and self.value is not None: | |||
| raise VariableDeclarationException( | |||
| f"{self._pretty_location} variables cannot have an initial value", self.value | |||
| f"{self._pretty_location()} variables cannot have an initial value", self.value | |||
There was a problem hiding this comment.
this is not correct, _pretty_location is a property. try to compile eg c: uint256 = 1
cyberthirst
reviewed
Nov 5, 2024
| @@ -1663,7 +1663,7 @@ class _CreateBase(BuiltinFunctionT): | |||
| @process_inputs | |||
| def build_IR(self, expr, args, kwargs, context): | |||
| # errmsg something like f"Cannot use {self._id} in pure fn" | |||
| context.check_is_not_constant(f"use {self._id}", expr) | |||
| context.check_is_not_constant(f"Error: {self._id} is not a constant") | |||
There was a problem hiding this comment.
this is not correct, check_is_not_constant takes 3 args, only 2 provided
see eg:
@pure
def foo(a: address):
b: address = create_minimal_proxy_to(a)
|
Hello, even if the fixes were made, I'm not sure this PR is relevant. When #3994 was created, and |
|
Hi there.
Are there other relevant and present issues I can attend to? How can I
identify old issues that have already been fixed? Good day.
…On Tue, Nov 5, 2024, 09:48 cyberthirst ***@***.***> wrote:
Hello, even if the fixes were made, I'm not sure this PR is relevant.
When #3994 <#3994> was created,
pretty_location was a function
and _CreateBase.build_IR didn't use f-string which is no longer the case
—
Reply to this email directly, view it on GitHub
<#4340 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BD64XCF2WIFYI5W5DESID2LZ7CA5HAVCNFSM6AAAAABQ5BWAXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJWGU3TCOBVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…build_IR
What I did
I updated issue in VariableDecl.validate() and update string formatting in build_IR codes.
How I did it
I cloned the repo and fixed that part of the code.
How to verify it
run pytest
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Improved: Updated VariableDecl.validate() to correctly use self._pretty_location() for consistent variable location formatting.
Fixed: Modified _CreateBase.build_IR to use an f-string in context.check_is_not_constant, ensuring self._id is properly displayed in error messages.
Cute Animal Picture
It's a cute piglet.
