Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow initiation of exchange to contain a VPR. #400

Conversation

wes-smith
Copy link
Collaborator

  • allows a client to get information about what the server will need to complete an exchange before making calls that might result in issuance.

- allows a client to get information about what the server will need to complete an exchange before making calls that might result in issuance.
exchanges.yml Outdated
Comment on lines 137 to 138
response from the server, if the server will need a Verifiable Presentation from the client during the exchange, or a
400 error if the server will issue in response to an empty body.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a 400 error if the server will issue in response to an empty body

This last bit is not quite clear, probably just needs more words and a grammar fix.

exchanges.yml Outdated
Comment on lines 136 to 138
to start the exchange will result in either a Verifiable Presentation Request response from the server,
if the server will need a Verifiable Presentation from the client during the exchange, or a
4XX error if the server will issue in response to an empty body.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to start the exchange will result in either a Verifiable Presentation Request response from the server,
if the server will need a Verifiable Presentation from the client during the exchange, or a
4XX error if the server will issue in response to an empty body.
to start the exchange will result in either a Verifiable Presentation or a Verifiable
Presentation Request that conforms to the client's request, or a 4xx error.

exchanges.yml Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@msporny msporny merged commit 5d12fbe into main Jul 16, 2024
1 check passed
@msporny msporny deleted the 387-consider-allowing-a-client-to-request-information-about-an-exchange-via-non-empty-post-body branch July 16, 2024 19:31
@TallTed TallTed mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider allowing a client to request information about an exchange via non-empty post body
3 participants