Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs with Manual Activation Example: example tab content seems to be a very unsual use-case... #3142

Open
moloko opened this issue Oct 11, 2024 · 1 comment
Assignees
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Feedback Issue raised by or for collecting input from people outside APG task force

Comments

@moloko
Copy link

moloko commented Oct 11, 2024

in the Accessibility Features section of this example it states:

Note that since the first element in every tabpanel is a focusable element (i.e., a link), the tabpanel is not included in the page Tab sequence. To make it easy for screen reader users to navigate from a tab to the beginning of content in the active tabpanel, it is recommended that all tabpanel elements in a tab set are focusable if there are any panels in the set that contain content where the first element in the panel is not focusable.

This seems to me to be a very unusual set up for an example - I would suggest it's not very likely that, in a real-world Tabs interaction, the first element in every tab panel would be a link.

It might, therefore, make for a better example if you were to change this so that:

  • the example doesn't have a link as the first element in each panel
  • the example gets updated to show how to handle that (far more common) setup, and:
  • the explanatory note updated to mention that you don't need to set the tab panel elements as focusable when you know for sure that the first element in each tab panel is focusable?
@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Feedback Issue raised by or for collecting input from people outside APG task force labels Nov 5, 2024
@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Issue 3142 - Tabs example feedback.

The full IRC log of that discussion <Jem> Topic: Issue 3142 - Tabs example feedback
<Jem> jon: we dont' make tab pannel focusable.
<Jem> mck: we have the focusable tab panel. https://www.w3.org/WAI/ARIA/apg/patterns/tabs/examples/tabs-automatic/
<jongund> https://www.w3.org/WAI/ARIA/apg/patterns/tabs/
<Jem> mck: it would be great idea to add some info regarding the difference between two examples. - focusable tab pannel.
<Jem> github:https://github.com//issues/3142
<Jem> it would be a great idea to add some info to distinguish two examples and to address the raised issue - focusable tab pannel info to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Feedback Issue raised by or for collecting input from people outside APG task force
Development

No branches or pull requests

3 participants