Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent usage of options variable #1948

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix inconsistent usage of options variable #1948

merged 1 commit into from
Sep 20, 2023

Conversation

Kieun
Copy link
Member

@Kieun Kieun commented Aug 24, 2023

Closes #1947


Preview | Diff

Copy link
Member

@nsatragno nsatragno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@timcappalli timcappalli removed their assignment Sep 13, 2023
Copy link
Member

@emlun emlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@agl agl merged commit baf774a into w3c:main Sep 20, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Sep 20, 2023
SHA: baf774a
Reason: push, by agl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Kieun Kieun deleted the kieun-1947 branch September 20, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent variable reference of attestation and attestationFormats in the steps
7 participants