Add backup flags to virtual authenticator #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting and changing the backup eligibility (BE) and backup state (BS) flags through the virtual authenticator API. Fixed: w3c#1987
MasterKale
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Thank you for taking this on, @nsatragno, this looks great!
The only thing I could think to suggest is that we call it defaultBackupEligible and backupEligible over ...Eligibility, but looking at the current state of the spec right now we seem to use "eligibility" more often than "eligible" so I don't think I have a strong case here:
emlun
reviewed
Nov 22, 2023
emlun's suggestion to change the `it` to be explicit. Co-authored-by: Emil Lundberg <emil@emlun.se>
|
+@pascoej for review from webkit. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 30, 2023
Allow webauthn's virtual authenticator to to set default and per credential backup eligibility (BE) and backup state (BS) flags. Expose this through the devtools API. Defaults can be set per authenticator using VirtualFidoDevice::State. This sets the flags for both credentials created by executing the CTAP make credential command, and credentials injected through State's Inject* functions. A future CL will expose this through webdriver. See w3c/webauthn#1999 Bug: 1504858 Change-Id: Ic53570f9acb2e10396161472bbccc8c39fefa759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5054633 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/main@{#1231469}
timcappalli
approved these changes
Dec 6, 2023
pascoej
approved these changes
Dec 12, 2023
github-actions bot
added a commit
that referenced
this pull request
Dec 13, 2023
SHA: cf35363 Reason: push, by nsatragno Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting and changing the backup eligibility (BE) and backup state (BS) flags through the virtual authenticator API.
Fixed: #1987
Preview | Diff