Adding example of localhost as allowed host/origin #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterKale
approved these changes
Feb 7, 2024
abergs
commented
Feb 14, 2024
abergs
changed the title
nsatragno
approved these changes
Feb 21, 2024
abergs
commented
Feb 21, 2024
sbweeden
approved these changes
Feb 21, 2024
pascoej
approved these changes
Feb 21, 2024
agl
approved these changes
Feb 21, 2024
nsatragno
approved these changes
Feb 21, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 21, 2024
SHA: 1a72b38 Reason: push, by nicksteele Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #2018 (and is irrelevant if #2018 is not merged) by adding an example of a valid origin for localhost. I expect people will have varying opinions on this, but since @MasterKale and I both thought of adding it, I thought I'd at least type it up and post it.
Marking as draft until dependency on #2018 is merged.
Preview | Diff