Fix indentation of step to invoke authenticatorMakeCredential #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current indentation renders this step as a sub-step of "For each credential descriptor C in pkOptions.excludeCredentials", meaning the operation is to be invoked once per `excludeCredentials` entry and not at all if `excludeCredentials` is empty. The indentation appears to have been broken in commit b44009c (originally 7acc1d5) in PR #1366, caused by a mix of tab and space characters being replaced with just spaces.
emlun
force-pushed
the
issue-2025-invoke-makeCred-indentation
branch
from
288deae
to
e239ee5
Compare
MasterKale
approved these changes
Feb 21, 2024
agl
approved these changes
Feb 21, 2024
nicksteele
approved these changes
Feb 21, 2024
github-actions bot
added a commit
that referenced
this pull request
Feb 21, 2024
SHA: bfe8f63 Reason: push, by emlun Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2025.
The current indentation renders this step as a sub-step of "For each credential descriptor C in pkOptions.excludeCredentials", meaning the operation is to be invoked once per
excludeCredentialsentry and not at all ifexcludeCredentialsis empty. The indentation appears to have been broken in commit b44009c (originally 7acc1d5) in PR #1366, caused by a mix of tab and space characters being replaced with just spaces.Preview | Diff