Add topOrigin to the limited verification algorithm. #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add topOrigin to the limited verification algorithm.
timcappalli
changed the title
emlun
reviewed
Aug 7, 2024
Co-authored-by: Emil Lundberg <emil@emlun.se>
emlun
force-pushed
the
zacknewman-patch-1
branch
2 times, most recently
from
4bb4027
to
3d0cb0a
Compare
emlun
force-pushed
the
zacknewman-patch-1
branch
from
3d0cb0a
to
60fc0e8
Compare
|
I added a requireTopOrigin parameter and extended the verification steps to use it to decide backwards compatibility with L2. I also deleted the crossOrigin parameter as its value is now equivalent to topOrigin being defined. |
4 tasks
|
@simoneonofri @plehegar, I would like to make a non-member patent licensing |
timcappalli
approved these changes
Aug 28, 2024
agl
approved these changes
Aug 28, 2024
pascoej
approved these changes
Aug 28, 2024
|
From the call of 2024-08-28: we would merge this if the IPR bot would let us. Simone is going to try running the IPR approval process to get this merged. |
emlun
approved these changes
Sep 11, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 12, 2024
SHA: 403c2b3 Reason: push, by nadalin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Note: the IPR approval process was applied and concluded successfully. |
github-actions bot
added a commit
to nsatragno/webauthn
that referenced
this pull request
Sep 18, 2024
SHA: 403c2b3 Reason: push, by nsatragno Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
topOriginto the limited verification algorithm.Fixes #2102.
Preview | Diff